fix: circuvent meilisearch bug with empty objects #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2024
navinkarkera
force-pushed
the
navin/component-collection-api
branch
3 times, most recently
from
ce7f906
to
3e889a9
Compare
The indexing update is already handled by m2m_changed handler.
navinkarkera
force-pushed
the
navin/component-collection-api
branch
from
3e889a9
to
cd9eec9
Compare
navinkarkera
force-pushed
the
navin/component-collection-api
branch
from
1debf71
to
baa10fc
Compare
Using `get_collection_components` does not work in case of post_remove as the component is already removed from collection and we don't really need additional filtering as we already have pk_set from the signal.
rpenido
force-pushed
the
rpenido/navin/component-collection-api-fix-meilisearch
branch
2 times, most recently
from
ccb2c54
to
6543313
Compare
rpenido
force-pushed
the
rpenido/navin/component-collection-api-fix-meilisearch
branch
from
6543313
to
758334f
Compare
navinkarkera
force-pushed
the
navin/component-collection-api
branch
2 times, most recently
from
4409ddc
to
bdee940
Compare
…onent-collection-api-fix-meilisearch
navinkarkera
merged commit 793e7bc
into
navin/component-collection-api
28 of 41 checks passed
navinkarkera
deleted the
rpenido/navin/component-collection-api-fix-meilisearch
branch
navinkarkera
added a commit
that referenced
this pull request
Oct 12, 2024
…ction-api-fix-meilisearch fix: circuvent meilisearch bug with empty objects
navinkarkera
added a commit
that referenced
this pull request
Oct 15, 2024
…ction-api-fix-meilisearch fix: circuvent meilisearch bug with empty objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.